🎉 Celebrating 25 Years of GameDev.net! 🎉

Not many can claim 25 years on the Internet! Join us in celebrating this milestone. Learn more about our history, and thank you for being a part of our community!

Back to General and Gameplay Programming

C++ Delete An Enemy from a Vector

yusufabi · 2021-04-24T05:13:09

Hi i wrote this code for creating multiple enemies from enemy class int number = 10; std::vector<std::unique_ptr<enemy> > enemies1; for (unsigned i = 0; i < number; ++i) { enemies1.emplace_back(std::unique_ptr<enemy>(new enemy(sf::Vector2f(100 * i + 1500, 1000), sf::Vector2f(15, 10), sf::Color(255, 255, 255, 0)))); } //update for (unsigned i = 0; i < number; ++i) { enemies1[i]->update(); } //render for (unsigned i = 0; i < number; ++i) { window.draw(enemies1[i]->enemysprite); } everything is ok. Multiple Sprites are drawing on screen and moving and such. But my problem is i cant erase a single enemy from enemies1 vector. I learnt this code from a site and there is a sample code like this: if (!items1.empty()) enemies1.erase(std::remove_if(items1.begin(), enemies1.end(), [sprite](const std::unique_ptr <enemy> &e) { return e->rect.getGlobalBounds().intersects(sprite.getGlobalBounds()); }), enemies1.end()); but it doesnt work and program is stopping to work. Basically i tried this code for another array like this: std::vector<int> vect_array(10); std::vector<int>::iterator it = vect_array.begin() + 2;- vect_array.insert(it, 66);//add vect_array.push_back(21); vect_array.erase(std::remove(vect_array.begin(), vect_array.end(), 5), vect_array.end()); and it works. My question is what's wrong on top code? it works with numbers but i want to do same things with another array for spawn and delete sprites. I appreciate for every advice.

General and Gameplay Programming Programming C++ programming SFML Vector array GameProgramming erase class

Started by yusufabi April 21, 2021 07:59 PM

11 comments, last by Alberth 3 years, 2 months ago

yusufabi

Author

April 23, 2021 11:06 PM

alvaro said:
That's not at all the kind of thing I was talking about. Is the sf:: stuff important for your question? Can you make a tiny program that outputs something to standard out and still exhibits the relevant problem? Can you then post the entire program here so we can reproduce the problem ourselves?

as i said above i have problems with this code:

if (enemies1.empty()){

enemies1.erase(std::remove_if(enemies1.begin(), enemies1.end(), [sprite](const std::unique_ptr <enemy> &e) { return e->rect.getGlobalBounds().intersects(sprite.getGlobalBounds()); }), enemies1.end());

}

its not erasing last element of vector. i would like to erase enemies from my class this is my problem